Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase PHPstan level 1 #1707

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

datengraben
Copy link
Contributor

@datengraben datengraben commented Dec 24, 2024

Successor to #1706

Increases rule levels to 1.

Aims to hopefully find problems and helps fix or document them.

@datengraben datengraben added technical Non-functional changes (refactorings or increase test coverage) php Pull requests that update Php code dx Developer Experience (technical) labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.26%. Comparing base (9ba70a1) to head (80e5c68).

Files with missing lines Patch % Lines
src/Service/Holiday.php 0.00% 1 Missing ⚠️
src/Wordpress/CustomPostType/Map.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1707      +/-   ##
============================================
+ Coverage     50.25%   50.26%   +0.01%     
  Complexity     2726     2726              
============================================
  Files            99       99              
  Lines         11323    11324       +1     
============================================
+ Hits           5690     5692       +2     
+ Misses         5633     5632       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datengraben datengraben added this to the 2.10.1 milestone Jan 3, 2025
@hansmorb hansmorb modified the milestones: 2.10.1, 2.10.2 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience (technical) php Pull requests that update Php code technical Non-functional changes (refactorings or increase test coverage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants